Discussion:
otp in passmenu
Gildásio Júnior
2021-04-09 02:09:03 UTC
Permalink
Hi all,

I have the same demand as Alessandro Accardo mentioned in Sep 2018 [0].
He submited a patch, receive a feedback, updated it and I couldn't see
any other new feedback.

I had patched passmenu to support pass-otp too (in a bigger way than
he did). I'm sending my patch to receive some feedback and talk about
the demand we have.

Anyway, thanks for your work. pass and passmenu as well are projects
that I like a lot. Thank you.

PS: I didn't have experience contribut with git patches by email. So
please let me know if I did something wrong and how can get the right
path.

[0]: https://lists.zx2c4.com/pipermail/password-store/2018-September/003406.html
--
[]'s
Gildásio Júnior
Jonas Kalderstam
2021-04-11 14:05:50 UTC
Permalink
Post by Gildásio Júnior
I have the same demand as Alessandro Accardo mentioned in Sep 2018 [0].
He submited a patch, receive a feedback, updated it and I couldn't see
any other new feedback.
I wouldn't expect much in terms of a reply when you have "demands" on people working for free in their spare time..
Post by Gildásio Júnior
PS: I didn't have experience contribut with git patches by email. So
please let me know if I did something wrong and how can get the right
path.
See https://git-send-email.io for an excellent guide to git and email.
Kenny Evitt
2021-04-11 19:59:13 UTC
Permalink
I suspect Gildásio used "demand" but meant "request". Nothing else in
their email implies that they're 'demanding' anything from Jason, the
maintainer, or anyone else.



I think it might be reasonable for people to seriously consider
forking Pass. No one's obligated to do anything. But no one's
obligated to refrain from changing Pass, or refrain from sharing those
changes either.

(I'd strongly suggest picking a new distinctive name, or at least a
distinctive variation on "pass" or "password store".)

I suspect Jason considers Pass mostly complete as-is. And that's fine!
I mostly agree with that myself. My own previous patches were never
accepted, and Jason had good reasons for doing so.

But it's frustrating not having patches accepted, or running one's own
custom private 'fork'. If people want to make changes useful to them,
and share those changes with others, then a fork could make sense.
(It's a lot of work tho!)


On Sun, Apr 11, 2021 at 10:07 AM Jonas Kalderstam
Post by Jonas Kalderstam
Post by Gildásio Júnior
I have the same demand as Alessandro Accardo mentioned in Sep 2018 [0].
He submited a patch, receive a feedback, updated it and I couldn't see
any other new feedback.
I wouldn't expect much in terms of a reply when you have "demands" on people working for free in their spare time..
Post by Gildásio Júnior
PS: I didn't have experience contribut with git patches by email. So
please let me know if I did something wrong and how can get the right
path.
See https://git-send-email.io for an excellent guide to git and email.
Gildásio Júnior
2021-04-15 11:41:17 UTC
Permalink
Yeah, thanks Kenny for made me clear. By "demand" I mean something like
"I would like this" not "I want this in my desk tonight".

My main purpose with the original message was to understand why the
Alessandro's patch wasn't more discussed/merged and receive feedbacks to
made my patch better.

I like the fork idea, maybe I'll do something like this (actually just
this patch I'm thinking now).
I suspect Gildásio used "demand" but meant "request". Nothing else in their
email implies that they're 'demanding' anything from Jason, the maintainer,
or anyone else.
I think it might be reasonable for people to seriously consider forking
Pass. No one's obligated to do anything. But no one's obligated to refrain
from changing Pass, or refrain from sharing those changes either.
(I'd strongly suggest picking a new distinctive name, or at least a
distinctive variation on "pass" or "password store".)
I suspect Jason considers Pass mostly complete as-is. And that's fine! I
mostly agree with that myself. My own previous patches were never accepted,
and Jason had good reasons for doing so.
But it's frustrating not having patches accepted, or running one's own
custom private 'fork'. If people want to make changes useful to them, and
share those changes with others, then a fork could make sense. (It's a lot
of work tho!)
On Sun, Apr 11, 2021 at 10:07 AM Jonas Kalderstam <
On 9 April 2021 04:09:03 CEST, "Gildásio Júnior" <
Post by Gildásio Júnior
I have the same demand as Alessandro Accardo mentioned in Sep 2018 [0].
He submited a patch, receive a feedback, updated it and I couldn't see
any other new feedback.
I wouldn't expect much in terms of a reply when you have "demands" on
people working for free in their spare time..
Post by Gildásio Júnior
PS: I didn't have experience contribut with git patches by email. So
please let me know if I did something wrong and how can get the right
path.
See https://git-send-email.io for an excellent guide to git and email.
--
[]'s
Gildásio Júnior
Loading...